-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clock_nanosleep to freebsd and netbsd #1922
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Overall it looks good to me but I'm not sure this( |
Thanks for the review. After submitting this PR, I have a couple more concerns
regarding redox OS, I searched for |
Please note that OpenBSD doesn't support `clock_nanosleep'. For others BSD, I dunno.
|
So, I'm happy to extend the support for |
Yep, totally agree. I'll force push the change I should have made. |
Should I add clock_nanosleep for freebsd 11? clock_nanosleep appears to have been added in 11.1, so it wouldn't work for 11.0 |
Turns out |
The change itself looks good to me, r=me once the above nit is resolved. |
Thanks! |
📌 Commit a6c451d has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12 |
fixes #1921